Sh/fix deploy sharing rules #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Sep 13, 2024
QA Notes✅ : steps 1&2 produced same behaviors, same outputs ➜ ../../oss/plugin-deploy-retrieve/bin/run.js project deploy start --metadata SharingCriteriaRule
Deploying v61.0 metadata to test-tln3scfhdpfi@example.com using the v61.0 SOAP API.
Deploy ID: 0AfDR00003Q7I740AF
Status: Failed | ████████████████████████████████████████ | 3/3 Components | Errors: 2
Component Failures [2]
================================================
| Type Name Problem Line:Column
| ───── ───────── ────────────────── ───────────
| Error Lead.g Not in package.xml
| Error Lead.test Not in package.xml
Warning: SharingGuestRule, Lead.g, returned from org, but not found in the local project
Warning: SharingOwnerRule, Lead.test, returned from org, but not found in the local project
vs (current) sf project deploy start --metadata SharingCriteriaRule
› Warning: @salesforce/plugin-api is a linked ESM module and cannot be auto-transpiled. Existing compiled source will be used instead.
Deploying v61.0 metadata to test-tln3scfhdpfi@example.com using the v61.0 SOAP API.
Deploy ID: 0AfDR00003Q7Hcu0AF
Status: Succeeded | ████████████████████████████████████████ | 0/0 Components✅ : retrieved via MD, same behavior overwriting existing .sharingRules file with less info (we only requested criteria) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
SharingRules were not being converted properly by child type due to an incorrect definition in the registry. This would result in errors thrown when trying to deploy SharingRules using a command like:
sf project deploy start -m SharingCriteriaRule:Account.Test_Rule1Adds conversion snapshot tests to ensure SharingRules can be converted by the SharingRules type or a child type, both to mdapi format and source format.
What issues does this PR fix or reference?
@W-16554846@
Test Suggestions: